Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

nft preview card using flex-box

Riccardo•100
@RZwartenbol
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Oscar Bocanegra•235
    @obocanegra-dev
    Posted about 2 years ago

    Hello Riccardo! 👋

    Congratulations on your excellent work in the Frontend Mentor challenge! 🎉 You've done a great job, and I want to highlight some suggestions to further improve your project:

    It's a good practice to use semantic elements in HTML. For example, instead of using a card container <div class="card-container">, you could consider using a <main> element and then use <section> elements to group related content within the card. This will help improve the structure and accessibility of your code.

    When it comes to headings, if there's only one, it's preferable to use an <h1>, as it represents the main heading of the page. This will help search engines and screen readers better understand the hierarchy of your content.

    For icons that are used purely for decoration and have no informational purpose, it's better to leave the alt attribute empty. This way, screen readers can skip the description of those elements and provide a better accessibility experience.

    For interactive parts of the design, such as buttons or links, it's recommended to use the appropriate tags (<button> or <a>, respectively). This will help users clearly identify interactive areas and improve the usability of your project.

    Finally, I would recommend creating a README file for your project. This file can serve as a guide for other developers and explain the purpose and functionality of each part of the project. This will help effectively share your work and facilitate the understanding of your code by others.

    I hope you find these suggestions helpful. Remember, they are only recommendations to enhance your project. Keep up the great work and continue improving your skills!

    Wishing you much success in your future projects! 🚀✨

    Best regards, Oscar

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub