@PhoenixDev22
Posted
Hi Lucas,
Congratulation on finishing another Frontend mentor challenge.
Another great solution! I have some suggestions regarding your solution, if you don't mind:
- The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) For this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>
.
2:If clicking the image would navigate the user to another page to see the NFT, here use <a>
.
- You should have used
<a>
to wrapEquilibrium #3429
.
- The link wrapping the equilibrium image (
image-equilibrium
) should either haveSr-only
text, anaria-label
that indicates where the link navigate the user(not describes the image).
- If you wish to draw a horizontal line, you should do so using appropriate CSS. Remove the
<span class="line"> </span>
, you can useborder-top:
to the avatar's part.
- To use more semantic tags , you may use
<figure>
and<figcaption>
for the avatar's part.
- For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in (`icon-view).
- The alternate of the avatar image should not be avatar, itβs meaningless. You can use the creator's name
Jules Wyvern
.
- There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML. The icon view doesnβt really need to be in the HTML. You can use CSS for it.
- Great work with animations, you have added some nice animations, so it's best to make sure that the animations are off for the users who requested to minimize the amount of non-essential motion it uses.. You can use the
prefers-reduced-motion query
to do that.
Aside these, Excellent work! Hopefully this feedback helps.
Marked as helpful
@correlucas
Posted
@PhoenixDev22 Thank you for this detailed feedback, I'll for sure apply the changes!
@PhoenixDev22
Posted
@correlucas Youβre welcome. Happy coding!