@Miculino
Posted
Hey @JuHnr
Congrats on completing this challenge! Your design looks quite nice and it's responsive as well!
Just a few suggestions based on your final solution and Github repo:
-
You have a vertical scrollbar that shouldn't be there. It's probably caused by the footer. Try using absolute positioning on the footer and or / reduce the space below the card
-
The hr line should be a different color and also more thin. Btw, you can achieve the same effect in a simpler way by just setting a border top on the .third element
-
It's a bad practice to use fixed px values for your width / height properties when building a responsive layout. Consider building your layout around the content available. You don't need height property at all in this project.
-
Look into relative units and try to implement those over px unit https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Values_and_units
Hope this helps. Keep up the good work!
Marked as helpful
@JuHnr
Posted
@Remus432 Thanks for your helpful feedback ! I'll try to apply your advices for the next project. Also I did try to set a border top on the .third element but it didn't work, so I came back to the hr line.. I would be grateful to have an example of correction for this part.
