Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Oops! You need to be logged in to do that
Not Found
Oops! You need to be logged in to do that
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFTchallenge with CSS custom properties and Flexbox

P

@Christ-Kevin

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View Challenge

Design Comparison

SolutionDesign

Report

7

Accessibility Issues

10

HTML Issues

View Report

Community Feedback

Byron 1,950

@byronbyron

Posted

Not bad @Christ-Kevin

I'd suggest having a look at the accessibility/html issues flagged by the FE mentor report 👍

  • All page content should be contained by landmarks
  • Bad value auto for attribute height on element img: Expected a digit but saw auto instead.
  • Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.
  • etc.

Other than that looks good! The massive height is a new one as well 😆

0


P

@Christ-Kevin

Posted

@byronbyron, thankyou for the feedback. But I have a question. What do you mean with "(...) The massive height is a new one as well " ? do you mean that the height of my container is massive ? or do you mean something else. If I made something wrong with this "massive height", could you explain me how i could avoid it ? Do you have a kind of solution ?

0

Please focus on giving high-quality, helpful feedback and answering any questions Christ-Kevin might have. Here are some key points to consider:

  • Does the solution include semantic HTML?
  • Is it accessible, and what improvements could be made?
  • Does the layout look good on a range of screen sizes?
  • Is the code well-structured, readable, and reusable?

You can read our community guidelines if you're unsure what to post.

Slack logo

Join our Slack community

Join over 100,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!