Skip to content
Submitted over 3 years ago

NFT-Preview Challege

Vaibhav Sachdeva•70
@sachdevavaibhav
A solution to the NFT preview card component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This is my first challenge on Front-End Mentor. Is my css code readable and maintainable. If no, then what are the things that I can improve. Your feedback is appreciated.

Code

Please log in to post a comment

Log in

Community feedback

  • Omar Mohy•670
    @omarmohy98

    Good morning@sachdevavaibhav, wonderfully done! The code is remarkably responsive. Below is my feedback on potential improvements!

    1.) Instead of <div class="main"> , let's replace that with <main> element and make it the top level in your code. Doing so will give your code more semantic meaning, will allow screen readers to know THIS is your main content and Fix the issues appear in Accessibility Report.

    2.) Try to control images' width & height in style.css not in <img> element in your index.html.

    If you found my feedback helpful, please mark this comment as helpful. Wonderfully done. Happy coding!

    Marked as helpful
  • Sameh•430
    @SamehCode

    @sachdevavaibhav: oh man ur great. i hope i be like you once. if could anyone tell me some tips and tricks and some great content i could learn more and more from.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord