NFT-Preview-card component

Community feedback

• 

  Hexer•3,620

  @EmmanuelHexer

  Posted over 3 years ago

  Nice work man. Keep it up

  00
• 

  learningtogetherua•230

  @learningtogetherua

  Posted over 3 years ago

  Hi! Good job. I advise you not to use a vertical flex scheme in this task. Use bottom margins

  02
• 

  Lorenzo Franco•480

  @Lfrancos

  Posted over 3 years ago

  Hello Akinyemi!

  This is looking really good, congratulations!!

  There is something that is happening and it used to happened to me as well and it is that if you scale your screen up (meaning changing the height of the screen) you will see that half of the card is missing and even if I try to scroll up I'm not able to see what you have there. I encourage you to use in your body element "min-heigth: 100vh" instead of what you have that is "height: calc(100vh - 1px);". You will see that this is going to help you with that problem.

  The last thing is that for accessibility you should add an element that has meaning for the the search engine. For this exercise I think you could use the element "main" that way the search engine would know that this is the main content and will know what your website is about.

  Hope this helps : )

  01