Frontend Mentor | NFT-Preview-Card coding challenge solution

Solution retrospective

The hardest part on the challenge: I had a while not being able to complete the challenge because of the view Icon- Layout. the truth is that i found out many ways to do it but i was too frustrated with it that i wouldn't understand how it works.

Which areas of your code are you unsure of? since i just came back to the challenge after 3 months, i have to say that my CSS looked very bad to me, however did not have much time to redo.

Do you have any questions about best practices? No questions about it at all. Just need to practice more.

Community feedback

Abdul Khalid 🚀• 72,160

@0xabdulkhalid

Posted about 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Jaykler• 30

@Jaykler

Posted about 1 year ago

@0xAbdulKhalid Thanks for the feedback much appreciated

Abdul Khalid 🚀• 72,160

@0xabdulkhalid

Posted about 1 year ago

@Jaykler Glad you found it helpful ! 🤠

NFT-Preview-Card

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community