NFT-Preview-Card

Solution retrospective
The hardest part on the challenge:
I had a while not being able to complete the challenge because of the view Icon- Layout. the truth is that i found out many ways to do it but i was too frustrated with it that i wouldn't understand how it works.
Which areas of your code are you unsure of? since i just came back to the challenge after 3 months, i have to say that my CSS looked very bad to me, however did not have much time to redo.
Do you have any questions about best practices? No questions about it at all. Just need to practice more.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @0xabdulkhaliq
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord