@faha1999
Posted
Hello, Ansh Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:
- You might want to use semantic tags like the
<main>
to wrap your code, instead ofdiv
. like
<main class="container">
</main>
This would help improve accessibility.
-
remove
margin
&padding
from thebody
-
add the below code to the
.container
. It will center everything
body {
justify-content: center;
align-items: center;
display: flex;
min-height: 100vh;
/* padding: 0 1em; */
/* max-width: 700px; */
/* margin-top: 5rem; */
/* margin-left: auto; */
/* margin-right: auto; */
/* margin-bottom: auto; */
}
-
use modern CSS reset
https://piccalil.li/blog/a-modern-css-reset/
-
active-state of
h3
&p span
.equi:hover, .name:hover{
cursor: pointer;
color: #25e6eb;;
}
a small transition
will be more attractive.
-
Instead of using
px
, use relative units likerem or em
to get better performance when the information on your page needs to be resized for multiple screens and devices.REM
andEM
apply to all sizes, not justfont-size
. You can code your entire page inpx
and then, at the very end, use the VsCode pluginpx to rem
to perform the automatic conversion px to rem -
fixed the other HTML validation error form the report.
I hope it will work. Happy coding.
Marked as helpful