Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

NFT-preview-card-component

Simon•40
@SimonMartorano
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


  • I used a CSS reset I found on google, I don't know if that's the best one.
  • I first made the mobile version, but when scaling the browser to desktop it still looked good, so I did not change any sizes on desktop version. Is that ok?
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Sandro•1,150
    @sandro21-glitch
    Posted over 2 years ago

    Hi Simon

    Here are some suggestions for your code

    HTML

    Use semantic elements:

    Make sure to use appropriate HTML5 semantic elements such as header, footer, article, main, nav, etc. to give structure to your content.

    Alt text for images:

    Make sure your images have descriptive alt text to help users who are using screen readers or have slow internet connections.

    Use CSS to separate the presentation of your content from your HTML. This will make it easier to maintain your code and make changes to the design of your website.

    Consider using preconnect to speed up loading time by establishing a connection to external resources before they are needed.

    CSS

    You could use CSS Custom Properties to store the width and max-width of the .card class, this way you can easily change the width and max-width values in one place.

    You could use CSS variables for the font-families and weights instead of hard-coding them.

    Consider using media queries to adjust the styles for different devices.

    Otherwise, it looks great.

    Good Luck

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub