Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

NFT-preview-card-component

Adham-16•30
@Adham-16
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my Second task, I will be very happy for your helpful comments.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Don•380
    @eldon6219
    Posted over 1 year ago

    hello adham !

    congrats on finishing your secound challenge here in frontend mentor where you will get better challenge after challenge :D

    i like your solution and i think i can help you to update it and more helpful

    • HTML

    1- instead of using <div class='container> try to use the HTML semantic elements more in this situation you should use <main> that should include all your codes and for better accessibility

    -CSS

    1- try to use the CSS reset look it up it will help to reset all the properties in the code

    2- make sure to use min-height:100dvh so that the element get to the center of the page and using 'dvh' so that it's more responsive

    3- NEVER EVER use width:300px as the px insead use rem or em to make it more responsive same with the padding and the margin

    4- in box shadow we are trying to make it as realistic as possible so i think you should lower it a bit of something like this box-shadow:0 0 12px 24px rgba(0,0,0,0.15)

    other than that you did a good job and keep going never quit you will get it eventually and you will become 1% better day after day i hope you find this helpful HAPPY CODING

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub