Danilo Blas• 6,300
@Sdann26
Posted
Congratulations on finishing this challenge, CARREON!
I would only recommend you to use some methodology for the naming of your classes as BEM but maybe you have seen it unnecessary as it is a small project. What I would mention is to change the <div class="attribution"> to <footer class="attribution"> since you are using it as this in your project, besides all the tags with content inside should be inside landmark tags (nav, main, footer, aside).
That's all I could recommend you, you've got 10 out of 10 hehe.
Good Coding!
Marked as helpful
0
CARREON• 300
@byCARREON
Posted
@Sdann26 Thanks Danilo, I actually did this challenge a while ago so I didn't know about BEM and stuff, but now I've been implementing BEM in most of my recent challenges :)
0
