@PhoenixDev22
Posted
Hello Nassim,
Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:
HTML
- The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..)
for this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use
<button>
. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use<a>
.
- The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you.
- For any decorative svgs, each
svg
tag should havearia-hidden="true"
andfocusable=āfalseā
attributes to make all web assistive technologies such as screen reader ignore those svgs in (icon-view, icon-ethereum, icon-clock ).
- Profile images like that avatar are valuable content. The alternate text of the avatarās image should not be
empty
. You can use the creator's nameJules Wyvern
. Read more how to write an alt text
- If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<hr>
, you can useborder-top:
to the avatar's part.
- For middle part of the card
class="card__balance-container"
, you can use an unordered list<ul>
, in each<li>
there should be<svg>
and<p>
. That way you can align them centrally.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site using target=ā_blankā attribute , you can expose your site to performance and security issues.
There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after
. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view doesnāt really need to be in the HTML. You can use CSS for it.
Overall, Your solution is good. Hopefully this feedback helps.
Marked as helpful
@Nassim555
Posted
@PhoenixDev22 thank you so much for this comment i has a lot of information and some new attributes that i've never heard of before which i'll definitely look into thank you again
@PhoenixDev22
Posted
@Nassim555 Glad to help. Happy coding!