nft-prevview-card-component

Community feedback

• 

  PhoenixDev22•16,830

  @PhoenixDev22

  Posted about 3 years ago

  Hello Simen Hagen,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you (not describes the image).

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in ( icon-ethereum, icon-clock ).

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Hopefully this feedback helps.

  12

  Marked as helpful
• 

  David•7,960

  @DavidMorgade

  Posted about 3 years ago

  Hello Simen, congrats on finishing the challenge, you did a really good job with the component layout!

  1. I would like to recommend you BEM, is one of the greatest naming convention for vanilla CSS and also one of the best approach when using SASS/SCSS, you will not regret using BEM cause you will always identify your classes and get an unique name on each of them!

  2. Try adding also screenshots of your project into your readme file, you can take screenshots of the current webpage on firefox just by rightclicking and selecting "take screenshot"

  Hope my feedback helps you! good job!

  11

  Marked as helpful