Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

no flexbox, grid or positioning utilized.

Jason Lee• 10

@JLee2011

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are alternatives to center the div vertically without using positioning or flexbox?

Is the best practice to work in px or %? % made the div overly large when resizing the browser, but i thought using px for layout is not best practice...or am I misunderstanding something conceptually.

Community feedback

P
Grace• 27,950

@grace-snow

Posted

Set a width 100% but also a max width in rem on the card. That stops it growing too large.

Use rem for font size, never px.

Make sure the wrapper (eg body) has a little padding to stop content hitting the sides of the screen

This looks pretty good overall. The onky thing that definitely needs changing in the html is the image alt text. This is not good "image-qr-code" because it is not readable, it's been written like it's code when this should be a normal written string of text just like any other visible content would be. It should describe the image briefly and should not include words like "image" because it is already on an image tag. For this image, I would recommend alt text say something like "QR code to frontendmentor.io"

0

@areklaz

Posted

Why do you want to center it without flex? It's the simplest way.

The best practice is basically using responsive units like rem, em or %. But it doesn't mean you can't use px at all. Try to use rems as font-size and margin/padding just like you (almost) did here.

0

Jason Lee• 10

@JLee2011

Posted

@areklaz Thanks for replying. Without flex just because the course I am taking has not yet covered this theme.

The original margins I used were in % but when the browser window was resized then the rendered card was so huge that the qr-code-img size would exceed the viewport.

0
Ahmed Ouni• 60

@midoox01

Posted

Working with % is better for responsive designs for fonts there is em and rem you should check out this tutorial to better understand responsive design. https://www.youtube.com/watch?v=srvUrASNj0s&ab_channel=freeCodeCamp.org

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord