Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Non-responsive solution (HTML/CSS/Flexbox)

P
Lairdfire 60

@Lairdfire

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • Any suggestions how can I improve on it ? -How can I make it responsive so the desktop an,d mobile designs are correct ?

Community feedback

Christian 970

@FLCHRIS

Posted

Hi there! ✌️, congrats on completing this challenge. 🥳🎉

I can see that your solution is good, but there are some improvements to your solution. You are not using the main tag to wrap your main content, I recommend you that you do. For more details HERE

In your CSS code, I see that you have a small reset, that's ok, but you can improve it with the following more popular resets.

Answering your last question, Its design is good, it adapts to mobile and desktop devices, You don't need media query.

Another way can be as follows:

body {
height: 100vh;
padding: 9.5rem 0rem 9.4375rem 0rem;
font-size: 15px;
background: var(--light-grey, #D5E1EF);
display: grid;
place-content: center;
}

I hope I've helped

Happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord