Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Nothing

@PayalSasmal10

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please provide feedback. It will help me to improve my skills.

Community feedback

Abdul 8,560

@Samadeen

Posted

Hey!! Cheers 🥂 on completing this challenge.. .

Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="img-qr"> instead of <div class="img-qr">.

  • Your footer should be <footer class="attribution"> instead of <div =attribution>

  • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <p class="bold-para">Improve your front-end skills by building projects</p> should be <h1 class="bold-para">Improve your front-end skills by building projects</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  • Images must have alternate text - Its hard for screen readers to pick up messages from images without alt text.. Its always advisable to include alt text to aid screen reader

This should fix most of your accessibility issues.

. Regardless you did amazing... hope you find this helpful... Happy coding!!!

Marked as helpful

0

@PayalSasmal10

Posted

Hi, Thank you so much for your help. It actually helped me to understand more.

0

@Elkordy-eg

Posted

it is not the same look

you should make the main section 100vh then make a container inside with 320px for example then center it check my code

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord