Skip to content
Submitted over 2 years ago

React notification list with styled-component

react, styled-components
Vinícius Pereira Nascimento•20
@vinycius-pereira
A solution to the Notifications page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Could my code get any cleaner? I organized in three main components, but to my mind there might be some room for improvement.

Code

Please log in to post a comment

Log in

Community feedback

  • madhaus•1,040
    @festsnusa

    Hi there! Congratulations for completing this challenge.

    I'm not quite sure if implementing React was necessary, because your styling component written in JS is kinda huge. You could minimize it using mixins in sass.

    Also, I've noticed that:

    • the whole item is unclickable. I guess if you click on an item, notification counter should decrease by 1 and an item itself should change its color;
    • when you cllick on "mark as read", notification counter should be invisible;
    • perhaps profile pictures and photo with chess should act as if there are links.

    Hope you find my feedback useful. Happy coding.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord