Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

nteractive-rating-component (HTML,CSS,JS)

CO•80
@melco10
A solution to the Interactive rating component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Which areas of your code are you unsure of?

  • I'm unsure of how i build my javascript for me it can be better code. but this code work for me and also I'm struggling on my logic of how I'm gonna apply a submit rate(1-5) but overall working. I wish I'll add some warning state when there's no number input but I don't really know where to start and my javasscript are only limited. but overall feel so good in the end.

Feel Free to leave suggestion!.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Assurance Chioma Ikogwe•410
    @Aik-202
    Posted almost 3 years ago

    Hi Co, Nice work!!!!. But I have some suggestions. For the JavaScript,

    1. From the cards, it's already obviously that the user is only suppose to choose from 1 to 5, so there's no need testing for that. Rather it should be something like this. if (!rateNum) //that is rateNum is undefined { //error message } else { //submit rating }

    This way you get to provide a check for when the user does not enter any input.

    For the html

    1. Try changing that h2 heading to h1, it will solve ya accessibility issue as there must be an h1 heading in your html...

    2. Add alt to all your images, you can see why here

    3. I feel like the link google.com wrapped around the star image is not necessary. What were you trying to achieve with that?🤔🤔🤔

    4. You can remove the link embedding the submit button, as it's not serving any purpose there.

    Hope, this helps.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub