Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NTF preview card component using Sass

#sass/scss

@lucianakyoko

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


One of the first challenges that I worked on. Appreciate any feedback. :)

Community feedback

@MojtabaMosavi

Posted

1- "left" and "right" are only decorative elements and <p> element is much suited for describing textual content, if it crossed you mind to use <span> I think you shoud've gone with that instinct because there is no other html tag that describes the purpose of those elements better.

2- In implementation of "card__profile-name" you trying to simulate a the behavior of a link with an span, which is not a good practise because on burdens you with extra unwished job, for instance with css you only got the visual behavior of a link by you need to write additional js for the functional behavior, this is great example of why you always should prioritize native html element, in this case in would be better to use a link element.

Keep coding :=)

0
Nam HaÏ 820

@Nam-Hai

Posted

Try to avoid giving child the same border-radius as its parent. It's a UX design phenomenon which makes this corner feel off

watch this : https://freebiesupply.com/blog/cool-design-tip-nested-rounded-corners/ It might help you in the futur

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord