Submitted over 2 years ago

Orden Summary Component

Pablo Rizzieri•60

@PabloRizzieri

A solution to the Order summary component challenge

Preview Code

Solution retrospective

In this challenge i tried to make him the fast as i can to test my skills using HTML and CSS

Any feedback its welcome!!

Code

Please log in to post a comment

Community feedback

Adriano•42,870
@AdrianoEscarabote
Posted over 2 years ago
Hi Pablo Rizzieri, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- All page content should be contained by landmarks, you can understand better by clicking here: click here

We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:
```
<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>
```
ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
```
<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>
```
It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...👍
Marked as helpful

Vanza Setia•27,715

@vanzasetia

Posted over 2 years ago

Hello, Pablo Rizzieri! 👋

I have a few suggestions for this solution.

Remove width: 100% from the body element. By default, it already fills the entire page horizontally.
Some changes that I made on my browser's dev tool.

body {
    /* width: 100%; */
    /* height: 100vh; */
   min-height: 100vh;
    display: grid;
    place-items: center;
    justify-content: center;
    font-family: 'Red Hat Display', sans-serif;
    background-color: var(--pale-blue);
}
Note: use min-height instead of height. This way,
the body element will allow growing if ever needed.

.main-container {
    /* width: 370px; */
    /* height: 600px; */
    border-radius: 30px;
    /* overflow: hidden; */
    background-color: white;
   max-width: 23.125rem;
}
Note: use max-width to prevent the card from
filling the entire page while still allowing it to shrink

Use single class selectors for styling whenever possible instead of id. id has high specificity which can lead to a lot of issues on the larger project. It's best to keep the CSS specificity as low and flat as possible.

I hope this helps!

Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord