@denielden
Posted
Sorry, I forgot... the link to the css sheet is skipped because in the repository you named the css
folder in uppercase. You can correct it by writing it in lowercase :)
Marked as helpful
Looking to hire developers?
Hello everyone,
This is my first challenge in Frontend. I just learn html and css from Udemy and I want to practice what i learned. I would like to know what would you recommend me to change to improve my code. Thank you in advance to take a moment.
Best regards!
@denielden
Posted
Sorry, I forgot... the link to the css sheet is skipped because in the repository you named the css
folder in uppercase. You can correct it by writing it in lowercase :)
Marked as helpful
@denielden
Posted
Hi Yousra, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
main
tag and wrap the card for Accessibilitydiv
with absolute
positioning is now deprecated, it uses modern css like flexbox or grid
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent containerwidth: 25rem and padding-bottom: 2rem
to top-container
classbackground: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
Overall you did well :)
Hope this help and happy coding!
Marked as helpful
@yousra10
Posted
@denielden Hello Deniel !! Thank you a lot for your taking time to detail and explain some tips to improve my coding!! It 's very helpful !! thank you a lot !!!
@purplehippo911
Posted
Hey @yousra10! Congratulations for finishing your first challenge!!🎈 The "top-container" does'nt have a width and a height added to it. Example:
.top-container {
width:200px;
height:200px;
}
And for the image in the background ("images/pattern ........") you can add it with css like this: (PS: remember to remove the image element for the "image/pattern" in the html)
.top-container{
background-image: url(/images/pattern-background-desktop.svg);
background-repeat: no-repeat;
}
If you misunderstood something I wrote just reply to me.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord