@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Consider using a button instead of an anchor tag for the "change" element, as buttons are designed for actions like altering the order's plan. Anchors are typically used for linking In this instance, the action involves altering the order's plan, making a button a more fitting choice.
- For icons, you should still use the alt attribute, but it should be empty (
alt=""
). This indicates to screen readers and other assistive technologies that the icon is decorative and that they should skip over it
- While setting
height: 100%;
is a common practice and even comes by default in some CSS resets, on smaller screens like mobile devices, the content can often exceed 100% of the screen. Consider usingmin-height: 100vh;
or amin-height
with dynamic viewport units instead for this type of components.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@gikdev
Posted
@MelvinAguilar Thanks, really helpful notes. I'm gonna use these tips on my next projects.