Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Order Summary Card (HTML and CSS)

Adam Elitzur•110
@AdamElitzur
A solution to the Order summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi guys, for some reason, when the screen gets too small, the text doesn't wrap, and it just gets cut off. Any suggestions? It might be something with the margin, I'm just not sure what the best way is to do this. Thanks!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia
    Posted over 3 years ago

    Hello, Adam! 👋

    Congratulations on finishing this challenge! 🎉

    I have some feedback on this solution:

    • Accessibility
      • Good job on leaving the alt="" empty for all decorative images! 👍
      • Add :hover effect for all interactive elements. It's much easier to identify any interactive elements if there are hover effects on them.
      • The attribution should be lived inside the footer.
    <body>
      <main>
        page content goes here...
      </main>
      <footer class="attribution">
          attribution links goes here...
      </footer>
    </body>
    
    • Don't use footer for the card content since it is not a full webpage. This is one chunk of content that all belong together and in a real website would sit with other content. The footer would be the attribution.
    • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users can navigate this website using keyboard (by using Tab key) easily.
    • There should not be text in span and div alone; instead wrap the text with a meaningful element.
    • Styling
      • To make the card perfectly in the middle of the page, you can make the body element as a flexbox container and remove the margin from the .card element.
    /**
     * 1. Make the card vertically center and
     *    allow the body element to grow if needed
     */
    body {
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh; /* 1 */
    }
    
    • Add padding to the body element to prevent the card from touching the browser edges or simply the card if filling the entire screen, on mobile view.
    • Best Practice (Recommended)
      • Remove the commented code. If another developer (it can be you in the future) wants to improve this solution, he/she might get confused about whether or not the commented code should be used or deleted.
      • Always use classes to reference all the elements that you want to style. Using id is going to make your stylesheet have high specificity (hard to maintain).

    That's it! Hope you find this useful! 😁

    Marked as helpful
  • Heli0s•670
    @zeerobit
    Posted over 3 years ago

    Good work completing this challenge.. The card size is too big for mobile view, add a max-width in your media query to make it smaller .

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub