Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Card

@peter-abah

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I had some issues trying to replicate the box shadow. I would appreciate any advice in replicating box shadows

Community feedback

@pikapikamart

Posted

Hey, awesome work on this one. Layout in general looks great and it is responsive.

It is great that lots of other already gave their feedback on this, really really nice. Just going to add some suggestions as well:

  • You don't need margin to center the content since it is not consistent right now for all users in terms of being centered. What you can do is that first remove margin on the main and on the body tag add:
    align-items: center;
    display: flex;
    flex-direction: column;
    justify-content: center;
    min-height: 100vh;

This way it will be centered properly.

  • Those decorative images on the site could have use an extra aria-hidden="true" attribute so that they will be totally hidden.
  • Music icon is decorative only so hide it using the method I mentioned.
  • Also when using alt attribute, avoid using words that relates to "graphic" such as "logo" and others. An img is already an image/graphic so no need to describe it as one.
  • annual plan should be a heading tag since it gives overview on what the section contains.
  • Also, when there is a text-content, always use meaningful element to wrap those and not only just span.

Aside from those, great work again on this one.

Marked as helpful

1

@peter-abah

Posted

@pikamart Thanks. I didn't use flex on the body element because I thought it was wrong is body is like the root element. I'll read up on the aria hidden attribute

0

@pikapikamart

Posted

@peter-abah Hey, for components like you can since there are no other content that is being used. But if you don't like it, maybe just use the main as the selector to be styled and just add another div inside it that will wrap the main content.

0
Njong392 70

@Njong392

Posted

if you used bootstrap, then implementing the shadow should be easy. Use the class shadow-none(no shadow), shadow(faint shadow), or shadow-lg(really visible shadow) for different... shadow levels(don't really know the word). You should try looking up the css attribute for that.

Marked as helpful

0

@peter-abah

Posted

@Njong392 I have not learnt bootstrap, I'll check it out. Thanks for the feedback

0
P
Ken 4,915

@kens-visuals

Posted

Hey @peter-abah 👋🏻

I have some quick tips to fix the position of the button.

  • Add these two lines to your button and you're done...almost 😃 All there's left to do is add :hover state. But I'll leave it to you as a challenge 🙃
width: 80%;
margin: .5rem auto;
  • What comes to box-shadow, here is a list of awesome shadow by CSS Scan, but there are tons of resources, In Frontend Mentor where you can find CSS box-shadow generators.

I hope this was helpful 👨🏻‍💻 everything else looks good, great job for the first project. Cheers 👾

Marked as helpful

0

@peter-abah

Posted

@kens-visuals Thank you. I will try to read up on box-shadow and the hover state

0
hardy 3,660

@hardy333

Posted

Few Suggestions:

  • Use hover effects on button and link components as it is on design files. For that use :hover syntax on element in css.
  • Make annual-plans component full width of the card..

Also What do you mean by replacing box-shadows ?

Marked as helpful

0

@peter-abah

Posted

@hardy333 Thanks for the feedback. I used :active instead of :hover. I will go back to correct it

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord