@vanzasetia
Posted
👋Hi There!
👍 Good job on completing your first challenge! I would recommend to delete the unnecessary file like the old README file. There's no reason to keep it on your repository.
More feedback:
- Delete the unused code (commented code). It makes the size of the file bigger with no reason and it may confused yourself and other developers (if you worked with a tem), whether or not this code should be deleted or used.
- 👍 Good job on leaving the
alt=""empty for the music icon (decorative image). You might want to addaria-hidden="true"to prevent the VoiceOver screen reader pronounce the image, when it shouldn't. - For the
bg-pattern, I would recommend to put that on thebodyelement instead of on themain. After that you can control the position by usingbackground-position. - I would recommend to put the
font-familyproperty on thebodyelement, since most of the elements likep, headings, will inherit thebodyfont family. - I notice that you style the page using the desktop first approach. I would recommend to style the page using mobile first approach, since most of the time in my experience I find out I write less CSS code. So, for the base styling (CSS code outside
@mediaquery) you style the mobile layout and then usemin-widthfor the@mediaquery.
That's it! Hopefully this is helpful!
Marked as helpful
@vanzasetia For sure, it is ! I'll be more attentive to the points your noted while doing the next challenge, your feedback come at the right time !
Thank you Vanza !
@vanzasetia I just completed the next challenge ! Here it is, if you wanna have a look : https://www.frontendmentor.io/solutions/stats-preview-card-component-with-scss-yF--9_glL
I've been careful about your recomandations, thanks again !
@vanzasetia
Posted
@FlorianJourde The quality of your code is increasing 📈.
I've just given my feedback on the your stats preview solution.
One thing, I recommend to use Markdown syntax to share your solution link.
[My solution](https://www.frontendmentor.io/solutions/stats-preview-card-component-with-scss-yF--9_glL)
It will render as:
Hint: You can see all the possible markdown syntax every time you want to write something on FEM input, by clicking the keyboard icon (above the input, right corner).
Marked as helpful
@vanzasetia
I would recommend to style the page using mobile first approach, since most of the time in my experience I find out I write less CSS code
Thanks again for that !
