Overall this is really good
Just some common beginner improvements to make
- swap section for a main element
- remove the alt text value on music icon and leave of intentionally blank like
alt=“”
. To ensure this is ignored by all assistive tech and search engines, I recommend adding aria-hidden true or role presentation - it’s best practice to include a css reset at the start of all css projects. That removes different browser styles. I like Andy bells modern css reset, but there are loads out there. Eg it will set images to be display block
- in css never put font size in px. Use rem instead
- probably change height 90vh to min-height.
There may be other things but all pretty minor so I’ll leave it there.
Good luck on your next challenge 👍
Marked as helpful
@aramatsolrac
Posted
@grace-snow I just finished all the improvements! I couldn't be more thankful for your feedback. I feel like I have learned a lot in the couple of days that I have been studying to put it into practice. Thanks again :)