@pikapikamart
Posted
Hey, great work on this one. Layout in general looks really great.
Cyrus already gave some great tips, just going to add some suggestions on the solution as well:
- It will be really for you to have :
html {
box-sizing: border-box;
}
*,
*::before,
*::after {
box-sizing: inherit
}
As one of you default styling. Using border-box: box-sizing
makes the element's size easier to handle.
- Always have a
main
element to wrap the main content of your page. On this one, the.container
selector could have usedmain
instead ofdiv
. - Also, avoid making a large element to be
position: absolute
as this removes the element from the flow. On your.container
you don't need these stylings:
position
left
top
transform
Then on your body
tag just add:
align-items: center;
display: flex;
justify-content: center;
By doing this, the element will always be centered and it is inside the flow. You can remove the position: relative
on the body
tag now.
- The vector image could use
aria-hidden="true"
attribute so that it will be totally hidden. - Always include a single
h1
on a page, since there is no visible text to be ah1
make theh1
a screen-reader only text, meaning it will use like ansr-only
class, theh1
will be placed as the first text-content inside themain
. You can search upsr-only
and how it is used. - Music icon can use
aria-hidde="true"
as well. - Great that you used heading tag on the annual-plan, but the choice is incorrect. When using heading tag, make sure you are not skipping a level. If you use
h5
make sure thath1, h2, h3, h4
are all present before it.
If you have any queries just drop it here okay. Again, great work on this one.
Marked as helpful
@abhijain2003
Posted
@pikamart thanks brother, your feedback is really helpful and learnable. as I had just completed my tutorials of frontend development and now i am just enhancing my skills so it will be better for me to make mistake, so that i can get another chance of learning from your feedback.
thanks brother,π€