Bryan Li• 3,550
@Zy8712
Posted
Hi there! Your site looks pretty good, nice work!
Some things I noticed when testing your site:
- for certain screen sizes the background doesn't extend to fit the full size of the screen, this may be due to how you implemented your css for your site
- I would suggest making sure your "wrapper" class has a width of 100vw so that it extends the full size of the screen
- for the background image you can use
background-size: cover;so it fits the full background - one other thing would be to use more semantic tags such as
<main>instead of having all divs. This is for accessibility purposes
Hope you find this feedback useful 👍
1
