Hi Jarek,
I recommend you
- use semantic elements for page structure as suggested above but also for any text. Annual plan can be a heading and the price a paragraph.
- only change should be a button. The others should be anchor tags I think. Look up the difference between the two elements.
- remove all the extra divs on this. There seen to be a lot of them. Remember you can do things like background images and use padding on the same element to make sure content doesn't overlap the images.
- as a general rule, use css grid for layouts that need to go along 2 axis, and flexbox when the layout only goes along 1 axis. This seems a little complicated at the moment
- the change font size is really small for.me viewing on mobile
- never have any font sizes in px. Use rem mostly. I see you are using em quite a bit - that should only be don't very intentionally when you want the size to inherit from a parents font size. I'm not sure you are using em for that reason here(?). It's not wrong or anything, just something to be aware of.
- always add focus visible styles to interactive elements. Make them obvious so keyboard users know where they are on the page.
Overall a good looking solution though, well.done
Marked as helpful
@airpoland
Posted
Hello Grace,
All your feedback is much appreciated. Thanks a lot for taking the time to look through my solution and put some high quality feedback. I restructured the solution so I think the HTML should be much more clear now.
Have a great day! Jarek