@Hassiai
Posted
wrap <div class="attribution"> within the footer tag to fix the accessibility issue.
Give the body a background-color of pale-bule, change the value of the background-size to contain and add a background repeat of no repeat.
There is no need for the height in .cardholder , if you still want to give it a height change the value to auto. give .textholder a padding value for all the sides. this a responsive replacement of the height.
You forgot to give . submit a box-shadow. give .cardholder a background-color of white.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful
@ilvdrskn
Posted
@Hassiai Thanks a lot for the tips! Do I understand correctly that for greater responsiveness of the page, fixed height values should be avoided, so that the container itself sets the desired one depending on the size of the content?
@Hassiai
Posted
@ilvdrskn fixed height will make the content overflow on smaller screens, for a responsive content use padding top and padding-bottom values.
Marked as helpful
