@andreasremdt
Posted
Hey @mayor-creator!
Nice job on this challenge, it looks good! Don't worry, responsive design is hard to do right in the beginning, you'll get better. If you like learning from videos, I can highly recommend Kevin Powell's YouTube channel, he explains things about web development in a great way, like this one about responsive design.
I went over your code and can give you a couple of tips:
- For the title ("Order Summary"), you used an
h2
. Since it's the only title on the page, it would be better to use anh1
. Each website should start with anh1
, since it's the most important title describing the page. If there are more headings, you can lower withh2
,h3
, and so on. - The design contains three interactive elements, and it was a good decision to use a
button
for "Proceed to Checkout". However, you didn't use interactive elements for the remaining two, which is confusing and hurts UX. Even though they are styled as links, clicking on them doesn't do anything. I recommend usinga
elements, for this challenge they don't need to point to anything. - Sticking to your interactive elements such as the button, it's a good practice to think about hover and focus styles. For example, you could make the blue darker on hover and even darker on focus, so that mouse and keyboard users know that this button is currently "selected".
- You have an
img.music_icon
element for the music icon. In this case, I would leave thealt
text empty, because it's mostly for screen reader users. They don't gain any benefit from this icon, it's purely for styling purposes and doesn't add anything to the content. So, you could writealt=""
to indicate that the image is not important, or even addaria-label="hidden"
to hide it from screen readers. - On smaller screens, the card is stuck to the bottom of the browser. Adding some margin (like you did for the top) would give it more breathing room and improve the styling.
Hope these tips help you out, let me know if you have any questions :-)
Marked as helpful