Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component

#bootstrap

@pleum3410

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,500

@denielden

Posted

Hello Pleum, You have done a good work! 😁

Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from main and article tags because with flex they are superfluous
  • remove max-width to the main tag to center the card horizontally and add the width of card to article tag
  • use min-height: 100vh instead of height, otherwise the content is cut off when the browser height is less than the content

Keep learning how to code with your amazing solutions to challenges.

Hope this help 😉 and Happy coding!

1

@pleum3410

Posted

Hi @denielden, Thank you for your help again

Took me awhile to understand the defferent between min-hight and hight with full viewport. Until i show the border of main element and see that content is overflow the container. i away put background color in body tag so i didn't notice the defferent

It still unclear about main because there are only one component in this challenge so i wrap it with main to prevent issue in report. I also use article to wrap a card component and divs inside card component. It this ok ? not sure what should be changed

1
Travolgi 🍕 31,500

@denielden

Posted

@pleum3410 you are welcome and keep it up :)

To understand how to use these 2 tags correctly, I suggest you read the documentation, it will also be clearer to you what I meant :)

1

@VCarames

Posted

Hey @pleum3410, some suggestions to improve you code:

  • Stay away from using libraries until you fully grasp the fundamentals. This is the purpose of this challenges.

  • To fix your background change the background-size: 100vw 50vh; to background-size: contain;.

  • The correct max-width for this challenge is 450px / 28.13rem

  • The ** Music Icons** serves no other purpose than to be decorative; It add no value. The Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • Your "cancel order" was created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

Happy Coding!

1

@pleum3410

Posted

Hi @vcarames Thank you for your suggestions

Size of component it getting closer to the design. I can't generate screenshort anymore so i'm gonna leave it there.

For libraries if you mean bootstrap i'll stick with this framework, All the job posts i see in my country away have bootstrap, react in the requirements. If i mastering bootstrap along with css it would be the best for job apply.

Thank you again

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord