@denielden
Posted
Hello Pleum, You have done a good work! 😁
Some little tips to improve your code:
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
frommain and article
tags because with flex they are superfluous - remove
max-width
to the main tag to center the card horizontally and add thewidth
of card toarticle
tag - use
min-height: 100vh
instead ofheight
, otherwise the content is cut off when the browser height is less than the content
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
@pleum3410
Posted
Hi @denielden, Thank you for your help again
Took me awhile to understand the defferent between min-hight and hight with full viewport. Until i show the border of main element and see that content is overflow the container. i away put background color in body tag so i didn't notice the defferent
It still unclear about main because there are only one component in this challenge so i wrap it with main to prevent issue in report. I also use article to wrap a card component and divs inside card component. It this ok ? not sure what should be changed
@denielden
Posted
@pleum3410 you are welcome and keep it up :)
To understand how to use these 2 tags correctly, I suggest you read the documentation, it will also be clearer to you what I meant :)