Order summary component

Please log in to post a comment
Log in with GitHubCommunity feedback
- @denielden
Hi Pavel, congratulations on completing the challenge, great job! 😁
Some little tips for optimizing your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- not use the css with
style
inside html but create aclass
in the css stylesheet - add
main
tag and wrap the card for improve the Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of texts - use
h1
for the tite of card and no a simplep
tag - add
margin: 0
to body to remove the side scroolbar of browser - use
min-height: 100vh
instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😉
Marked as helpful - @rachit0706
Great work,
But a suggestion for you will be to use relative lengths for height and width like rem, % etc rather than absolute lengths units like px because design is not responsive in mobile view
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord