Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component - BEM, CSS Flexbox

#accessibility#bem
Chris 40

@diru0

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! 🫵🏻

This is my solution to Order Summary Component challenge.

It was a lot of fun working on that challenge. I could put my current knowledge to work. My implementation will be updated in future when I find better solutions.

Thank you for your time and feedback, it really helps me to grow!

Community feedback

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.
  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

2

Chris 40

@diru0

Posted

@0xAbdulKhalid Thank you Abdul. I changed body height to min-height as you suggested. 👋🏻

1
Suleman 750

@legion40216

Posted

maybe you can improve on ur semantic html of main tag instead of div, But kudos bro the HTML and CSS is very clean and organized refrain from using height property.

Marked as helpful

1

Chris 40

@diru0

Posted

@legion40216 Thanks Suleman, I changed .card tag to main as you suggested. 🦾

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord