Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component challenge - HTML and CSS

Will Gordon• 20

@wcgordon1

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


The css was a little tricky for the music icon / Annual Plan / $59.99/year.

Initially, I was going to use CSS grid but quickly found this to not be a good solution. placed the elements in a div and used Flex instead. doh!

Overall, not very difficult. Nice to code without a tutorial and figure it out on my own. I start General Assembly Code bootcamp on 11/29/21.

Community feedback

Nick• 760

@Nick331102

Posted

Nice work. Good luck in your bootcamp

Marked as helpful

1

Will Gordon• 20

@wcgordon1

Posted

@Nick331102 Thanks Nick. I'm going to resubmit now after catching a few things. Hopefully, this won't delete our comments.

0
P
Grace• 27,950

@grace-snow

Posted

@wcgordon1 don’t resubmit!! Just push up new code/update your submitted solution. That’s the whole point of version control

0
P
Grace• 27,950

@grace-snow

Posted

Hello

Here is some ideas for improvements on this, most are really common beginner mistakes so don’t get discouraged. It’s good to pick these things up early 😊

  • headings must go in order. They are essential for giving structure to the document, nothing to do with styling. So annual plan needs to be a h2 here
  • no reason to have background image on an absolutely positioned div in the html. Just place the background image on the body, then swap that image in a media query for the desktop/mobile one
  • the grey box is definitely not an article. Div is fine, it has a heading and that’s all the structure you need semantically
  • what is it you expect proceed and cancel to do? Buttons are for actions, anchor tags for navigation. If these would take you to a next/previous page/step in a process they should be anchor tags
  • make sure all interactive elements have obvious focus-visible states to help keyboard users know where they are in the page. Usually this is not supplied by a designer and set globally for a site like a bold orange/blue outline
  • overall try to get a little closer to the design in terms of heading size, padding and the subtlety of the box shadow. You could do this challenge with no media queries (except the body background image), but I think the padding is slightly larger on desktop in the original designs.
  • never have font sizes in pixels. That’s important. Use rem most of the time, or em if you need to scale with the size of a parent (I can’t remember the last time that was necessary on a project though and only use em occasionally for padding)

That’s all I can remember from looking quickly at code before, but hope it’s a helpful start. Good luck

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord