Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component - HTML & CSS Flexbox

Pop Andrei 120

@pccipri

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would appreciate if you could tell me what you think about my solution.Let me know if u think I used maybe a bit too much flexbox. I'm a beginner so any advice is welcomed. Anyway thanks for taking the time to view my solution.

Community feedback

darryncodes 6,430

@darryncodes

Posted

Hi Pop,

Great solution, you should be proud!

At a glance a few thoughts from me:

  • it's not best practice to style using id's here is a few reasons why
  • your id="container" could be on the <main> tag instead of the additional <div>
  • a few tweaks to your design to help with that background image and centering things nicely in the viewport (you'll need to fix a few other parts of your design if you implement the following:
#container {
    background-image: url(images/pattern-background-desktop.svg);
    background-repeat: no-repeat;
    background-size: 100% auto; // ADD 100%
    background-color: hsl(225, 100%, 94%);
    display: flex;
    margin: auto;
    /* width: 1440px; */ //REMOVE
    /* height: 900px; */ //REMOVE
    justify-content: center;
    align-items: center;
    flex-direction: column;
    min-height: 100vh; // ADD
}

Marked as helpful

1

Pop Andrei 120

@pccipri

Posted

@darryncodes thanks a lot for taking your time to look over my solution and thanks for the advice I will look into it, just got one question why the min-height = 100vh on the container? Isn't that supposed to be less so that the footer has some space as well and not force the viewer to scroll down to view it?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord