Looking to hire developers?
Feedback welcome about my practices :D
@iprinceroyy
Posted
That's excellent work @jesusfrancisco88. You need to focus on some key points here:-
All the others are perfect. Hope it adds to your learning, Happy Coding :)
Marked as helpful
@madkn1311
Posted
Hello Fransisco,
You have designed the card quite well.
Here are some things that you need to change
You need to remove the background from your html code and place it in the styling of the body.
body
{
background-image: url("./images/pattern-background-desktop.svg");
}
To center the card vertically use min-height: 100vh in the body instead of plain height as min-height allows responsive behaviour and adjusts according to the screen sizes.
Always add an alt attribute to the images for better accessibility.
All the best for the next challenge 😊
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
