Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component using grid and media queries

Lichtβ€’ 50

@DeadParadox

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is appreciated :)

Community feedback

Rio Cantreβ€’ 9,710

@RioCantre

Posted

Hello there! Good job with this challenge. Viewing your solution, I think you should considered the following...

  • the hover state of the main button into this...
.payment-btn:hover {
  background: hsla(245, 78%, 79%, 1);
  cursor: pointer;
}
  • Add the background image in the body rule set like this...
body {
  min-height: 100vh;
  font-size: 16px;
  font-family: "Red Hat Display", sans-serif;
  background-color: var(--pale-blue);
  display: grid;
  place-items: center;
  color: var(--desaturated-blue);
  background-image: url(images/pattern-background-desktop.svg);
  background-repeat: no-repeat;
}

and adjust the image in media queries for mobile

  • Wrap the attribution with footer tag

Hope this helps and Keep up the good work!

Marked as helpful

1

Lichtβ€’ 50

@DeadParadox

Posted

@RioCantre Right, I completely forgot about background-image. I was stuck on how to implement the background efficiently, and yeah, I forgot to swap to a footer tag but I didn't feel like pushing a commit just for that. And if there was a hover state in the challenge, I must've missed it, good call!

Thanks for the feedback, much appreciated! :)

1
Anosha Ahmedβ€’ 9,340

@anoshaahmed

Posted

hey good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here

here is a list i made of accessibility issues & best practices

hope this helps :))

0

Lichtβ€’ 50

@DeadParadox

Posted

@anoshaahmed Uh, I'm a bit confused, in HTML documentation I cannot find any mention of an attribute called "role", also, I did wrap everything in <body> in <main> so I'm not sure where is this coming from. Could you explain?

0
Anosha Ahmedβ€’ 9,340

@anoshaahmed

Posted

@DeadParadox you had the attribution in a div tag, which was outside of main. but i see that u changed the div to a semantic footer tag, which is what i was tryna tell u

1
Lichtβ€’ 50

@DeadParadox

Posted

@anoshaahmed Ah I see, yes I saw that but I did not feel like pushing a commit just for one accessibility fix. Thanks for the feedback though!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord