Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component using HTML & CSS

Tushar Biswas 4,100

@itush

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I enjoyed the challenge very much.

I'd really appreciate if you could answer the following:

  1. What did I do wrong?
  2. What did I do right?
  3. How can I improve?

Thanks in advance :)

Community feedback

P
AK 6,700

@skyv26

Posted

Hi! Tushar, I hope you are well and good. I checked your work and I saw some issues.

  1. You background image is not centered properly (I am using 1366px screen laptop). Solution In your body tag, either add background-size: 100% auto; Or background- size: contain; It will set you background image at 100% screen width.

  2. I saw that you have used box-shadow but the color you chose is white. Always give shadow a tint color. So that your card or layout looks different or look little bit up from rest of design.

Overall Good Work. I think you need more practice in CSS.

Best Of Luck

Marked as helpful

2

Tushar Biswas 4,100

@itush

Posted

@skyv26 Fixed the issues as suggested. And yes, I need to practice more on CSS undoubtedly!

Thanks for your help :)

1
P
AK 6,700

@skyv26

Posted

@itush your welcome 🤗

0
ROCKY BARUA 1,090

@Drougnov

Posted

Hello, @itush. Nicely done. Here are something you may reconsider:

  • To make your HTML accessible don't use unnecessary divs. You can use main, section, article etc. instead of div.

  • Your background pattern doesn't work well on the big screen. You can use background-size: contain to make it fit the width.

  • On the card item the box-shadow color doesn't fit well. Try using black color with low opacity.

Happy coding and have a nice day.❤

2

Tushar Biswas 4,100

@itush

Posted

@Drougnov Thank you very much for the feedback. Fixed the issues as suggested.

Overusing div tags is something I always try to avoid. Using main, section & article tags makes more sense instead. Totally agreed. (For this challenge, only 2 div tags was used by me, which again could have been absolutely avoided, no argument there)

Thank you and Happy coding:)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord