@tesla-ambassador
Posted
Hey Kushyzee. This is pretty impressive, congrats on completing your challenge! Here's a few tips:
- To answer your question on background positioning, you can use the
background-position
css property more on this if you follow this link You could also set the background size to match that of the design usingbackground-size
css property. - The responsiveness is a little off between 810px - 1149px. I think it'd be okay if you centered it and reduced the width of the card component a little to let's say (80% because I think you preffer it to be a little wider)
- To fix your accessibility issue, you might want to enclose your <div> with the class "attribution" in a footer landmark. Happy coding and keep on coding!
Marked as helpful
@kushyzee
Posted
@tesla-ambassador Thanks so much for your feedback, I followed them accordingly and now i believe it's looking much better