Order Summary Component using HTML and CSS

Community feedback

• 

  Kent O'Sullivan•1,870

  @12Kentos

  Posted about 3 years ago

  Hey @mogs7,

  Nice job on completing this challenge! It's looking good. :)

  In response to your questions,

  I think your code is organized ok, but you will definitely want to start practicing now organizing your code in a way that makes sense to you, so when you come back to it months/years later it still makes sense. An easy way to organize code, is simply to add comments to it. That way you can look at the comment and easily know what the next section/sections of code are for.

  I think your html structure is fine. I didn't see any big issues with it, however I would suggest at some point looking into html naming conventions like BEM.

  I would suggest in the future you avoid selecting elements directly like you did in the following code.

  p{ color:hsl(224, 23%, 55%); font-size: 16px; }

  This will affect every single p element you have on the page, and in bigger projects this would affect a lot of your work.

  I would suggest either using a more specific selector, or better yet using a class. If you go the first route of using a more specific selector, this can lead to specificity wars, which is not a fun thing to deal with.

  Here's a really good video by Kevin Powell in which he gives some good suggestions on best practices.

  Kevin Powell Specificity

  Let me know if you have any other questions!

  11

  Marked as helpful