Order Summary Component With Only HTML and CSS

Community feedback

• 

  Nguyen Duy•245

  @koalalikecode

  Posted almost 4 years ago

  Congrats on finishing your challenge. It looks good for a beginner.

  However, you can improve your code by taking some steps:

  • Firstly, Instead of using a center tag <center>, you had better use a main tag like this `<main>your codes</main>
  • Secondly, you should use CSS for regulating the value of images' width and height <img class="musicicon" src="assets/icon-music.svg" alt="Music Icon" width="50%" height="50%">
  • Moreover, use your CSS to make margin, it will make your Html code clearer.<br> </br>
  • Finally, it will look better if you use an external CSS file instead of the internal one

  Aside from that, great work!

  00
• 

  Obuhri•165

  @obaryo

  Posted almost 4 years ago

  for the html issues, you should remove the styling of width, height and <center> and do it in your separate css file so that it's easier to style it. For the accessibility issue, it said that you should add a main class on your body, and you can change the <div class="attribution"> to <footer class="attribution"> to remove the accessibility issue.

  00
• 

  DOMINGOS JOSÉ GONÇALVES NETO•0

  @edvanio1888

  Posted almost 4 years ago

  I don't understand you, be clearer.

  00