@denielden
Posted
Hi Cellmix, congratulations on completing the challenge, great job! π
Some little tips for optimizing your code:
- For fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
- you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all
margin
fromcard
class because with flex they are superfluous - use flexbox properties to the body to center the card. Read here -> best flex guide
- use
min-height: 100vh
to main tag instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding π
Marked as helpful