@vanzasetia
Posted
Hi, Sebastian! 👋
Nice solution! It's great that you are using the main
element to wrap the card content. It's also a good thing that you are wrapping all the interactive elements with interactive elements, in this case, with button
elements.
However, I have two things that I would like to suggest,
- Firstly, I would recommend fixing all the accessibility issues that have been reported by Frontend Mentor. Having an accessible is one of the most important things that you need to consider as a frontend developer. You could click the Learn More link to get more information about the issue and how to solve it.
- Second, I would suggest specifying the
type
of anybutton
elements. By doing that, you will prevent thebutton
from behaving unexpectedly, like submitting. In this case, you can specify the type of them astype="button"
.
Overall, you have done a great job with the HTML markup and I think if you fix all the accessibility issues, it would make your website more accessible to more people, especially for the people who rely on assistive technology. 😉
That's it! Hope you find this useful! 😁
Marked as helpful