Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary content

Alif 40

@alifjs

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


In chrome dev tools my website looks fine in iphone Se.But in real life it doesn't. Any help regarding that would be much appreciated.

Community feedback

Anar 700

@anar-sol

Posted

Hello!

  • I don't think this component needs to bigger on large viewports. You can set a max-width, the same for all viewports.
  • Don't set the height for the component, but let it be automatically calculated from the content. You set it to 90vh on mobile, but it isn't sufficient to contain all the elements, the cancel button is overflowing.

Marked as helpful

1

Alif 40

@alifjs

Posted

@anar-sol Thank you for your kind feedback!

0
Alif 40

@alifjs

Posted

@anar-sol In chrome dev tools, my site looks fine for iphone Se.But in my iphone Se it doesn't.Any ideas?

0
Anar 700

@anar-sol

Posted

@alifjs What problem do you have on you iphone exactly?

0
Alif 40

@alifjs

Posted

@anar-sol 'Proceed to payment' and 'Cancel order' overflows. And 'image of the girl' is not positioned at the start of the container as expected (there is some space on top of it).

0

@AGutierrezR

Posted

On the other hand, both "Proceed to Payment" and "Cancel Order" are buttons, so you could use the <button> tag for them, and use some styling composition with the classes.

First, you could create a base style on a .btn class, set some padding and text-align on it, and a background-color: transparent and use this class on both buttons.

Then set the bright blue background color on a .btn-primary class and use both classes on the "Proceed to Payment" button

Marked as helpful

0

Alif 40

@alifjs

Posted

@AGutierrezR Thank you for your generous feeback!

0

@AGutierrezR

Posted

Hi @alifs! Awesome job!

Well, one of the issues that I'm seeing with your code is that you set a fixed height on the container, so you don't have space to grow vertically and the image can change size horizontally.

Try not to set a fixed height and allow the content to set it, play with the padding and margin to get the result that you want.

Marked as helpful

0

Alif 40

@alifjs

Posted

@AGutierrezR Thanks! I understand.I am now removing the 'height'.I don't know what made me add it in the first place lol.Thank you so much

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord