Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Order Summary — Vanilla HTML & CSS

Jack•10
@jkufa
A solution to the Order summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Primarily looking for feedback on how I am sizing the card and the inner music image, and any feedback for how make the page responsive more responsive. Thanks!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • hardy•3,640
    @hardy333
    Posted almost 4 years ago

    hey, your card looks good, good job.

    -I suggest to use semantic html tags such as <section></section> for container and <article></article> for card, it will be little better.

    • use more padding, tiny little bit more xD.
    Marked as helpful
  • Brooke Wargnier•155
    @brookewargnier
    Posted almost 4 years ago

    For responsiveness:

    I just finished up this challenge as well, and one way I found that works is setting up a separate css page with a media query so I could better control the different sizes between a desktop version and a mobile version.

    That being said, I didn't get it to be a super smooth transition, but it still allowed me to set up different cases so I could set the d different fronts/ backgrounds/ buttons/ card sizes between the mobile version and the desktop version.

    I found this webpage helpful in the explanation of how to implement it: https://www.w3schools.com/cssref/css3_pr_mediaquery.asp

    Marked as helpful
  • faiyaz rahman•260
    @faiyaz-rahman13
    Posted almost 4 years ago

    you're designing is nice but you can make it look more good. Here is some stuff which if you've applied it would look more good. first, whenever you start doing any task don't write you're code under the body tag instead write it inside the main tag <main><main/> it would specify you're working more. secondly, you can make the card size small and fit it in the middle so that it would look nicer and it would beautify the webpage. third, the div where you have written the pricing. you should make the border-radius a little less and make the background a little more transparent so that it would give an aesthetic vibe. fourth, last but not the least. you could have made the fonts a little small on the mobile version because it looks tremendously big there. so I hope these things will make you're working more efficient and make it better. hope you find it useful.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub