Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Order-Summary First-Solution using HTML and CSS

Julia Fidison MAHANDRISOA•90
@Julia-Fidison
A solution to the Order summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello, any feedback will be welcome. Especially, on the media query part to make the site more responsive.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Christian Addy•20
    @criscrispy
    Posted over 3 years ago

    Hello Julia,

    Great work in general. A few things you want to take note of :

    • Since you have a separate style.css file, you can move all the styles to the style.css and get rid of the styles tag in the html file. So basically, this below will be moved to the styles sheet. .attribution { font-size: 11px; text-align: center; } .attribution a { color: hsl(228, 45%, 44%); }

    • You did not include the image folder so the images did not load on your site.

    • For image queries, as you already have the @media only screen and (max-width:450px) {...} which is targeting screen sizes for max-width:450px and below. You can include some media queries that target more break points.

    320px — 480px: Mobile devices (You can keep the 450px in your example)

    481px — 768px: iPads, Tablets

    769px — 1024px: Small screens, laptops

    1025px — 1200px: Desktops, large screens

    1201px and more —  Extra large screens, TV

    Read more about media queries : Free code camp article on media queries

    Marked as helpful
  • Julia Fidison MAHANDRISOA•90
    @Julia-Fidison
    Posted over 3 years ago

    Thanks a lot for your feedback. I really appreciate.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub