@alex-kim-dev
Posted
Hi Daniel, good job on this challenge! I've been looking through it and here's what I want to mention:
- it's not necessary to wrap every image in a
<figure>
element, it's required when you need to add a caption to it:
<figure>
<img src="elephant.jpg" alt="Elephant at sunset">
<figcaption>An elephant at sunset</figcaption>
</figure>
- the
alt
attribute with description must be present on images, it helps screen reader users and displays on the screen if an image isn't loaded - the margins of body and main elements collapsing, resulting in weird body positioning (with an offset on the top). There's a great post on the topic
- the
<main>
element already has semantics,role="main"
is not necessary - use either
<a>
or<button>
, but don't mix both like<a role="button">
Good luck!
Marked as helpful
@dannzdev
Posted
@Alex-K1m thanks a lot i know these feedbacks will help me improve. I made corrections, if you want to check it again it would be nice. I tried to make it less weird xD
@alex-kim-dev
Posted
@dannzdev Looks good, have fun with the next challenge!