Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Order-summary-component-main

accessibility
Gastón Federico Nahuel Gómez•370
@Morfeo1997
A solution to the Order summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


It was a really simple challenge so I try using several @media selectors to improve accessibility. Any suggestions are welcome.

Fue un reto bastante simple asique intente usar varios selectores de @media para mejorar la accesibilidad. Cualquier sugerencia sera escuchada.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Kirsten ✨•460
    @ofthewildfire
    Posted about 2 years ago

    Hey! First off, fantastic job, it looks amazing, I just have some small changes I think might be helpful.

    1 - Your music icon image is stretched, its in a flex-container so we can solve that by adding a align-items: center to align the items vertically. This distributes the whitespace and makes it nice and centered

    .plan-container {
        width: 100%;
        height: 20%;
        display: flex;
        flex-direction: row;
        align-items: center;
        padding: 2vh 3vw;
    }
    

    2: Within your price-plan container you used a span and a paragraph and that is fine, totally, however, a paragraph has default margin and that default margin is causing a lot of space above it and making it look way too wide from the span. This can easily be fixed by removing the top/bottom margin on the paragraph element.

    .price-container > p {
        color: hsl(224, 23%, 55%);
        margin: 0;
    }
    

    -- and alternatively, you could also have used a ul/li to create this and it would have taken care of itself, seeing as <li> ... </li> are in-line and the flex-container would have nicely spaced all components out, but that is just personal opinion really. You did aweome whichever method you prefer. --

    3: Your button and anchor tag hover states are missing the cursor: pointer to give it that micky-mouse hand on hover like your "Cancel order" element has. So adding cursor: pointer would just be it

    You did a really great job and I hope these are helpful additions. :)

    Happy Coding ~ Kaycee.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub