Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 7 months ago

Owner avatar recipe-page-main using responsive page

foundation
Kamal Alhejaili•60
@Kamalep
A solution to the Recipe page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of the first web page challenge, it takes around 5-7 days. the next time I'll do it on a day

What challenges did you encounter, and how did you overcome them?

the challenge was how to make media query, especially how to make image fit, I'm not finished yet,

What specific areas of your project would you like help with?

how to make the image fit on media query

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mayen•440
    @Mayen007
    Posted 7 months ago

    Hey Kamal! Your work is coming along beautifully—great job so far! Here’s some feedback to make your project even better:

    Image Responsiveness

    I noticed that your image overlaps the recipe container. To address this, you can make your image responsive by setting its width to 100% so it adjusts to the width of its parent container. This ensures that your image scales naturally and maintains its aspect ratio.

    Here’s an example CSS snippet you can use:

    img {
      width: 100%;
      height: auto; /* Maintains aspect ratio */
    }
    

    This approach eliminates the need for media queries to handle responsiveness in most cases.

    Simplifying the Markup

    It looks like the container-img div isn't adding much value to the structure. You can simplify your HTML by removing it and applying the necessary styles directly to the image element. This makes your code cleaner and easier to maintain.

    Keep up the fantastic work, Kamal, and happy coding! 😊

    Marked as helpful
  • Kamal Alhejaili•60
    @Kamalep
    Posted 7 months ago

    Thank you Mayen, i will take your notice, and I'll see what can I do

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub